Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan and @DamonU2)

packages/geoview-core/src/geo/layer/layer.ts line 709 at r1 (raw file):

            const legendLayerInfo = LegendEventProcessor.getLegendLayerInfo(this.getMapId(), payload.layerPath);
            // Ensure that the layer bounds and legend icons are set when the layer is loaded
            if (legendLayerInfo && !legendLayerInfo.bounds) LegendEventProcessor.getLayerBounds(this.getMapId(), payload.layerPath);

If bounds are not set but icons is, would it pass the function without triggering a logError?

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan and @jolevesq)

packages/geoview-core/src/geo/layer/layer.ts line 709 at r1 (raw file):

Yes, the catch is just there because it is required for an async function

Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @DamonU2 and @jolevesq)

packages/geoview-core/src/geo/layer/layer.ts line 716 at r1 (raw file):

              });

            this.#emitLayerLoaded({ layer: sender, layerPath: payload.layerPath });

Question: As it is, the emitLayerLoaded will be emitted before the queryLegend() has terminated. I don't remember if that's alright or not (based on the layer statuses). So, basically asking if that's what we want. If so, all good. If not, maybe we're missing an await here.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @DamonU2 and @jolevesq)

packages/geoview-core/src/geo/layer/layer.ts line 716 at r1 (raw file):

Reading the code again, it probably aligns with how it was before.
Therefore, my question should rather be, is the queryLegend() in LegendsLayerSet not good enough to do this over there instead of here? I'm likely missing some context explaining this change.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Alex-NRCan and @jolevesq)

packages/geoview-core/src/geo/layer/layer.ts line 716 at r1 (raw file):

Yeah, looking a little deeper, this probably isn't helping. We're having issues with some layers querying the legend before the style is set, and not updating once the style is there, but this doesn't fix that. Removed and I'll look elsewhere.

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alex-NRCan)